From scan-admin at coverity.com  Mon Jul  7 11:09:16 2025
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Mon, 07 Jul 2025 11:09:16 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <686baadc30885_1a1a892d27936c79a0243a9@prd-scan-dashboard-0.mail>

An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250707/b4590a8c/attachment.html>

From dridi at varni.sh  Mon Jul  7 14:09:48 2025
From: dridi at varni.sh (Dridi Boukelmoune)
Date: Mon, 7 Jul 2025 14:09:48 +0000
Subject: Coverity Scan: Analysis completed for varnish
In-Reply-To: <686baadc30885_1a1a892d27936c79a0243a9@prd-scan-dashboard-0.mail>
References: <686baadc30885_1a1a892d27936c79a0243a9@prd-scan-dashboard-0.mail>
Message-ID: <CABoVN9A0JWHrvFajNOb6V8=3Hu=3rfVvS2PcV3MQKScHntJsJA@mail.gmail.com>

I may have accidentally captured this in a test case.

https://github.com/varnishcache/varnish-cache/issues/4357

Dridi

On Mon, Jul 7, 2025 at 11:09?AM <scan-admin at coverity.com> wrote:

> Hi,
>
> The analysis for your project *varnish* has been successfully completed.
> You can view the results by clicking the button below:
>
> View Build Results <https://scan.coverity.com/projects/varnish>
> Build Details:
>
>    - *Build ID:* 707829
>    - *New Defects Found:* 1
>    - *Defects Eliminated:* 0
>
> Summary:
>
> We found 1 new defect(s) in this build. Please review and address them as
> needed.
>
> If you have any questions or need assistance, feel free to contact us:
>
>    - Email: scan-admin at coverity.com
>    - Visit our StackOverflow page
>    <http://stackoverflow.com/search?q=scan+coverity>
>
> Thank you for using Coverity Scan!
>
> Best regards,
>
> The Coverity Scan Admin Team
> _______________________________________________
> varnish-dev mailing list
> varnish-dev at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250707/148fb30e/attachment-0001.html>

From scan-admin at coverity.com  Thu Jul 10 07:53:46 2025
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Thu, 10 Jul 2025 07:53:46 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <686f718a8db3c_1d04092d27936c79a02437d@prd-scan-dashboard-0.mail>

An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250710/3e460818/attachment.html>

From nils.goroll at uplex.de  Fri Jul 11 07:42:06 2025
From: nils.goroll at uplex.de (Nils Goroll)
Date: Fri, 11 Jul 2025 09:42:06 +0200
Subject: who would have thought that gmtime_r uses a mutex?
Message-ID: <32a4b97e-d676-4271-bd50-5ee3215657f1@uplex.de>

Just dropping this here, not sure if it's worth doing anything about it 
(probably not). But I was really surprised...

from `perf report` of a synthetic benchmark:

- 12.52% cnt_synth 

    - 5.24% Resp_Setup_Synth 

       - 3.50% http_TimeHeader 

          - 3.16% VTIM_format 

             - 1.69% __lll_lock_wait_private 

                - 1.63% entry_SYSCALL_64_after_hwframe 

                   - 1.63% do_syscall_64 

                      - 1.56% x64_sys_call 

                         - 1.56% __x64_sys_futex 

                            - 1.56% do_futex 

                               - futex_wait 

                                  - 1.55% __futex_wait 

                                     - 1.32% futex_wait_setup 

                                        - 1.29% futex_q_lock 

                                           - 1.26% _raw_spin_lock 

                                                native_queued_spin_lock_slowpath 

             - 0.64% __lll_lock_wake_private 

                - 0.64% entry_SYSCALL_64_after_hwframe 

                   - 0.63% do_syscall_64 

                      - 0.61% x64_sys_call 

                         - 0.61% __x64_sys_futex 

                            - 0.61% do_futex 

                                 0.59% futex_wake 

             - 0.56% __GI___snprintf 

                  0.54% __vsnprintf_internal 

         0.86% http_PrintfHeader 



https://sourceware.org/git/?p=glibc.git;a=blob;f=time/tzset.c;h=0ddc20328717bcf695de370cb48c83b06a7e076b;hb=HEAD#l572 
called from 
https://sourceware.org/git/?p=glibc.git;a=blob;f=time/gmtime.c;h=ad6e8eb35233f6018607b938f303dc75323c8f6e;hb=HEAD#l26

maybe this is for simplicity of the code, but as `use_localtime` is zero, the 
stuff at the top of the function under the lock would not be required, _I think_ 
(am I wrong?).

Nils

-- 

Nils Goroll (he/him)

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstra?e 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink at jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x1DCD8F57A3868BD7.asc
Type: application/pgp-keys
Size: 3943 bytes
Desc: OpenPGP public key
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250711/c26358ff/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250711/c26358ff/attachment-0001.bin>

From scan-admin at coverity.com  Mon Jul 14 10:03:58 2025
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Mon, 14 Jul 2025 10:03:58 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <6874d60e50010_2111bf2d27936c79a0243d2@prd-scan-dashboard-0.mail>

An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250714/ecce4e8a/attachment.html>

From scan-admin at coverity.com  Mon Jul 21 09:10:34 2025
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Mon, 21 Jul 2025 09:10:34 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <687e040a61c74_281d2f2ea7f5d7b99894e2@prd-scan-dashboard-0.mail>

An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250721/0ce409b3/attachment.html>

From scan-admin at coverity.com  Mon Jul 28 10:09:57 2025
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Mon, 28 Jul 2025 10:09:57 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <68874c74239d3_23f0e2dd3d8507998907ca@prd-scan-dashboard-0.mail>

An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20250728/f677af22/attachment-0001.html>