The ticket exists: <br><br><a href="http://varnish-cache.org/ticket/649">http://varnish-cache.org/ticket/649</a><br><br>I need somebody to test it in linux, only check that it compiles OK.<br><br>I am new to Varnish, żeverybody can commit changes to trunk? or only admin users?<br>
<br>Thanks<br><br><br><div class="gmail_quote">2010/5/31 Poul-Henning Kamp <span dir="ltr"><<a href="mailto:phk@phk.freebsd.dk">phk@phk.freebsd.dk</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
Can I get you to open a ticket with this text in it, so we have<br>
a record of why we are doing this ?<br>
<br>
Poul-Henning<br>
<br>
In message <<a href="mailto:AANLkTik-i3Kh45hQTP4zVYzw50Kz2zGvT8xWdpYQS--q@mail.gmail.com">AANLkTik-i3Kh45hQTP4zVYzw50Kz2zGvT8xWdpYQS--q@mail.gmail.com</a>>, =?IS<br>
O-8859-1?Q?Jorge_D=EDaz?= writes:<br>
>--===============8061307876579297173==<br>
>Content-Type: multipart/alternative; boundary=0016e659f6d29162560487e1a818<br>
><br>
>--0016e659f6d29162560487e1a818<br>
>Content-Type: text/plain; charset=ISO-8859-1<br>
><br>
>Hello,<br>
><br>
>I am testing Varnish (r4576 <<a href="http://varnish-cache.org/changeset/4576" target="_blank">http://varnish-cache.org/changeset/4576</a>>) in<br>
<div class="im">>Solaris 10 5.10 Generic_120011-14 sun4v sparc SUNW,Sun-Fire-T2000.<br>
>We are planning to use a cache like Varnish or Squid and I have followed the<br>
>instructions in<br>
</div>><a href="http://letsgetdugg.com/2009/12/04/varnish-on-solaris/" target="_blank">http://letsgetdugg.com/2009/12/04/varnish-on-solaris/</a><<a href="http://letsgetdugg.com/2009/12/04/varnish-on-solaris/" target="_blank">http://letsgetdugg.com/2009/12/04/varnish-on-solaris/</a>><br>
<div class="im">>I have the same LINGER crash like in<br>
</div>>#660<<a href="http://varnish-cache.org/ticket/660" target="_blank">http://varnish-cache.org/ticket/660</a>>that has the same root cause<br>
>in<br>
>#649 <<a href="http://varnish-cache.org/ticket/649" target="_blank">http://varnish-cache.org/ticket/649</a>><br>
<div class="im">><br>
>I have trying to fix the bug and I have found *the problem is that solaris<br>
>setsockopt returns sometimes EINVAL* when it is no invalid parameters,<br>
>problem found in Java JVM in Solaris:<br>
</div>>* <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378870" target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378870</a><<a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378870" target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6378870</a>><br>
>*<br>
><a href="http://bugs.opensolaris.org/bugdatabase/view_bug.do;jsessionid=7141b1811572e415779f4a711a96?bug_id=6850464" target="_blank">http://bugs.opensolaris.org/bugdatabase/view_bug.do;jsessionid=7141b1811572e415779f4a711a96?bug_id=6850464</a><<a href="http://bugs.opensolaris.org/bugdatabase/view_bug.do;jsessionid=7141b1811572e415779f4a711a96?bug_id=6850464" target="_blank">http://bugs.opensolaris.org/bugdatabase/view_bug.do;jsessionid=7141b1811572e415779f4a711a96?bug_id=6850464</a>><br>
<div class="im">><br>
>I think the solution is to changed the definition of "TCP_Check" in *<br>
>libvarnish.h* only for Solaris*<br>
><br>
>/* In Solaris OS, errno == EINVAL is OK because setsockopt(3SOCKET) call<br>
>returns EINVAL when the connection is reset. */<br>
>#if defined (__SVR4) && defined (__sun)<br>
>#define TCP_Check(a) ((a) == 0 || errno == ECONNRESET || errno == ENOTCONN<br>
>|| errno == EINVAL)<br>
>#else<br>
>#define TCP_Check(a) ((a) == 0 || errno == ECONNRESET || errno == ENOTCONN)<br>
>#endif<br>
><br>
>Do you think it is ok to commit it to trunk ?<br>
><br>
>Thank you<br>
</div>>*<br>
><br>
>--0016e659f6d29162560487e1a818<br>
>Content-Type: text/html; charset=ISO-8859-1<br>
>Content-Transfer-Encoding: quoted-printable<br>
><br>
>Hello,<br><br><p><br>
>I am testing Varnish (<a class=3D"changeset" href=3D"<a href="http://varnish-cache.o" target="_blank">http://varnish-cache.o</a>=<br>
>rg/changeset/4576" title=3D"Tell FlexeLint=20<br>
>that we ignore returnvalues on purpose.">r4576</a>) in Solaris 10 5.10=20<br>
>Generic_120011-14 sun4v sparc SUNW,Sun-Fire-T2000. <br><br>
<div class="im">>We are planning to use a cache like Varnish or Squid and I have followed<br>
</div>> the instructions in <a class=3D"ext-link" href=3D"<a href="http://letsgetdugg.com/2=" target="_blank">http://letsgetdugg.com/2=</a><br>
>009/12/04/varnish-on-solaris/"><span class=3D"icon">=A0</span><a href="http://letsge" target="_blank">http://letsge</a>=<br>
><a href="http://tdugg.com/2009/12/04/varnish-on-solaris/" target="_blank">tdugg.com/2009/12/04/varnish-on-solaris/</a></a><br>
></p><br>
><br>
>I have the same LINGER crash like in <a class=3D"closed ticket" href=3D"htt=<br>
>p://<a href="http://varnish-cache.org/ticket/660" target="_blank">varnish-cache.org/ticket/660</a>" title=3D"defect: Varnish LINGER<br>
> crash in tcp.c (closed: duplicate)">#660</a> that has the same root=20<br>
>cause in <a class=3D"new ticket" href=3D"<a href="http://varnish-cache.org/ticket/64=" target="_blank">http://varnish-cache.org/ticket/64=</a><br>
>9" title=3D"defect: Varnish LINGER<br>
> crash on Solaris (new)">#649</a> <br><br>I have trying to fix the bug and =<br>
>I have found <strong>the problem is=20<br>
>that solaris setsockopt returns sometimes EINVAL</strong> when it is no=20<br>
>invalid parameters, problem found in Java JVM in Solaris:<br><br>
>* <a class=3D"ext-link" href=3D"<a href="http://bugs.sun.com/bugdatabase/view_bug.do=" target="_blank">http://bugs.sun.com/bugdatabase/view_bug.do=</a><br>
>?bug_id=3D6378870"><span class=3D"icon">=A0</span><a href="http://bugs.sun.com/bugda=" target="_blank">http://bugs.sun.com/bugda=</a><br>
>tabase/view_bug.do?bug_id=3D6378870</a><br>
> <br><br>
>* <a class=3D"ext-link" href=3D"<a href="http://bugs.opensolaris.org/bugdatabase/vie=" target="_blank">http://bugs.opensolaris.org/bugdatabase/vie=</a><br>
>w_bug.do;jsessionid=3D7141b1811572e415779f4a711a96?bug_id=3D6850464"><span =<br>
>class=3D"icon">=A0</span><a href="http://bugs.opensolaris.org/bugdatabase/view_bug.d=" target="_blank">http://bugs.opensolaris.org/bugdatabase/view_bug.d=</a><br>
>o;jsessionid=3D7141b1811572e415779f4a711a96?bug_id=3D6850464</a><br>
><br><br>I think the solution is to changed the definition of "TCP_Chec=<br>
>k" in <b>libvarnish.h</b> only for Solaris<strong><br><br><span style=<br>
>=3D"font-family: courier new,monospace;">/* In Solaris OS, errno =3D=3D EIN=<br>
>VAL is OK because setsockopt(3SOCKET) call returns EINVAL when the connecti=<br>
>on is reset. */</span><br style=3D"font-family: courier new,monospace;"><br>
><span style=3D"font-family: courier new,monospace;">#if defined (__SVR4) &a=<br>
>mp;& defined (__sun) </span><br style=3D"font-family: courier new,monos=<br>
>pace;"><span style=3D"font-family: courier new,monospace;">#define TCP_Chec=<br>
>k(a) ((a) =3D=3D 0 || errno =3D=3D ECONNRESET || errno =3D=3D ENOTCONN || e=<br>
>rrno =3D=3D EINVAL)</span><br style=3D"font-family: courier new,monospace;"=<br>
>><br>
><span style=3D"font-family: courier new,monospace;">#else</span><br style=<br>
>=3D"font-family: courier new,monospace;"><span style=3D"font-family: courie=<br>
>r new,monospace;">#define TCP_Check(a) ((a) =3D=3D 0 || errno =3D=3D ECONNR=<br>
>ESET || errno =3D=3D ENOTCONN)</span><br style=3D"font-family: courier new,=<br>
>monospace;"><br>
><span style=3D"font-family: courier new,monospace;">#endif</span><br style=<br>
>=3D"font-family: courier new,monospace;"><br><span style=3D"font-weight: no=<br>
>rmal;">Do you think it is ok to commit it to trunk ?<br><br>Thank you<br></=<br>
>span></strong><br>
><br>
>--0016e659f6d29162560487e1a818--<br>
><br>
><br>
>--===============8061307876579297173==<br>
>Content-Type: text/plain; charset="us-ascii"<br>
>MIME-Version: 1.0<br>
>Content-Transfer-Encoding: 7bit<br>
>Content-Disposition: inline<br>
><br>
>_______________________________________________<br>
>varnish-dev mailing list<br>
><a href="mailto:varnish-dev@varnish-cache.org">varnish-dev@varnish-cache.org</a><br>
><a href="http://lists.varnish-cache.org/mailman/listinfo/varnish-dev" target="_blank">http://lists.varnish-cache.org/mailman/listinfo/varnish-dev</a><br>
>--===============8061307876579297173==--<br>
><br>
<font color="#888888"><br>
--<br>
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20<br>
phk@FreeBSD.ORG | TCP/IP since RFC 956<br>
FreeBSD committer | BSD since 4.3-tahoe<br>
Never attribute to malice what can adequately be explained by incompetence.<br>
</font></blockquote></div><br>