<div dir="ltr"><div><div>Hi Weibin<br><br></div>I'm pretty sure this is #1184, which has since been fixed in both master[1] and 3.0[2].<br><br></div>Thanks though!<br><br><br>[1]: <a href="https://www.varnish-cache.org/trac/changeset/7c784d5c9d2dd959a5ea1a1bea5f7bbb4173437d">https://www.varnish-cache.org/trac/changeset/7c784d5c9d2dd959a5ea1a1bea5f7bbb4173437d</a><br>
[2]: <a href="https://www.varnish-cache.org/trac/changeset/e837c4bcd26218489576af899f563c66e6b0511f">https://www.varnish-cache.org/trac/changeset/e837c4bcd26218489576af899f563c66e6b0511f</a><br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Feb 22, 2013 at 8:17 AM, Weibin Yao <span dir="ltr"><<a href="mailto:yaoweibin@gmail.com" target="_blank">yaoweibin@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi folks,<div><br></div><div>This is a small patch, it fixes the segment fault caused by the failure assertion with the error gunzip return value.</div><div><br></div><div>I don't know if this patch is sufficient, it seems work for me.</div>

<div><br></div><div>Thanks.</div><div><br></div><div><div>diff --git a/bin/varnishd/cache_esi_fetch.c b/bin/varnishd/cache_esi_fetch.c</div><div>index ab86ac8..e3f80f3 100644</div><div>--- a/bin/varnishd/cache_esi_fetch.c</div>

<div>+++ b/bin/varnishd/cache_esi_fetch.c</div><div>@@ -270,8 +270,9 @@ vfp_esi_bytes_gg(struct sess *sp, struct http_conn *htc, size_t bytes)</div><div>                do {</div><div>                        VGZ_Obuf(sp->wrk->vgz_rx, ibuf2, sizeof ibuf2);</div>

<div>                        i = VGZ_Gunzip(sp->wrk->vgz_rx, &dp, &dl);</div><div>-                       /* XXX: check i */</div><div>-                       assert(i >= VGZ_OK);</div><div>+                       if (i < VGZ_OK) {</div>

<div>+                               return (-1);</div><div>+                       }</div><div>                        vef->bufp = ibuf2;</div><div>                        if (dl > 0)</div><div>                                VEP_parse(sp, ibuf2, dl);</div>
<span class="HOEnZb"><font color="#888888">
<div><br></div><div><br></div>-- <br>Weibin Yao<br>Developer @ Server Platform Team of Taobao
</font></span></div>
<br>_______________________________________________<br>
varnish-dev mailing list<br>
<a href="mailto:varnish-dev@varnish-cache.org">varnish-dev@varnish-cache.org</a><br>
<a href="https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev" target="_blank">https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev</a><br></blockquote></div><br><br clear="all"><br>-- <br><table style="font-style:normal;font-weight:normal;font-size:12px;line-height:1.5em;font-family:'Helvetica Neue',Arial,sans-serif;color:#666666;width:550px;border-top:1px solid #eeeeee;border-bottom:1px solid #eeeeee;margin-top:20px;padding-top:5px;padding-bottom:5px" border="0" cellpadding="0" cellspacing="0">

<tbody><tr>
<td width="100">
<a href="http://www.varnish-software.com" target="_blank"><img src="http://www.varnish-software.com/static/media/logo-email.png" style="float:left;margin-left:10px"></a>
</td>
<td>
<b style="font-size:14px;color:#222222">Dag Haavi Finstad</b><br> 
Developer | Varnish Software AS<br> Phone: +47 21 98 92 60<br><span style="font-weight:bold">We Make Websites Fly!</span></td>
</tr>
</tbody></table>

</div>