FYI: FlexeLint on dns-director

Poul-Henning Kamp phk at phk.freebsd.dk
Tue Aug 3 09:09:42 CEST 2010


Please try to eliminate as many as at all possible...


FlexeLint for C/C++ (Unix) Vers. 9.00d, Copyright Gimpel Software 1985-2009

[...]

--- Module:   cache_dir_dns.c (C)
                                                                 _
	struct sockaddr_in *bps = (struct sockaddr_in *) bp->ipv4;
cache_dir_dns.c  94  Info 740: Unusual pointer cast (incompatible indirect
    types)
                                          _
	if (bp->ipv4len != len || len <= 0)
cache_dir_dns.c  96  Info 775: non-negative quantity cannot be less than zero
_
}
cache_dir_dns.c  103  Info 818: Pointer parameter 'bp' (line 89) could be
    declared as pointing to const
cache_dir_dns.c  89  Info 830: Location cited in prior message
                                                                   _
	struct sockaddr_in6 *bps = (struct sockaddr_in6 *) bp->ipv6;
cache_dir_dns.c  113  Info 740: Unusual pointer cast (incompatible indirect
    types)
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)
                                          _
	if (bp->ipv6len != len || len <= 0)
cache_dir_dns.c  115  Info 775: non-negative quantity cannot be less than zero
_
}
cache_dir_dns.c  127  Info 818: Pointer parameter 'bp' (line 107) could be
    declared as pointing to const
cache_dir_dns.c  107  Info 830: Location cited in prior message
                            _
			addr, len));
cache_dir_dns.c  139  Info 740: Unusual pointer cast (incompatible indirect
    types)
                            _
			addr, len));
cache_dir_dns.c  142  Info 740: Unusual pointer cast (incompatible indirect
    types)
cache_dir_dns.c  142  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)
_
}
cache_dir_dns.c  145  Info 818: Pointer parameter 'dir' (line 131) could be
    declared as pointing to const
cache_dir_dns.c  131  Info 830: Location cited in prior message
                                                                _
	new->hostname = calloc(sizeof(char), strlen(hostname)+1);
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                    _
#... !(new->hostname != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "n
	assert(new->hostname != NULL);
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                       _
	strcpy(new->hostname, hostname);
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                        _
		return 0;
cache_dir_dns.c  291  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message
                                                               _
				new->hosts[host] = vs->hosts[i];
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... ew->hosts[host]) != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "
#... ssert((new->hosts[host]) != NULL); assert((new->hosts[host])->magic == 0x3
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... sts[host])->magic == 0x3336351d)) vas_fail(__func__, __FILE__, __LINE__, "
#... osts[host])->magic == 0x3336351d); } while (0)
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                          _
	new->nhosts = host;
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                _
	return 1;
cache_dir_dns.c  313  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message
                                          _
	pthread_rwlock_unlock(&vs->rwlock);
cache_dir_dns.c  330  Warning 534: Ignoring return value of function
    'pthread_rwlock_unlock(struct pthread_rwlock **)' (compare with line 234,
    file /usr/include/pthread.h, module cache_acceptor.c)
/usr/include/pthread.h  234  Info 830: Location cited in prior message
                                                  _
		pthread_rwlock_unlock(&vs->rwlock);
cache_dir_dns.c  334  Warning 534: Ignoring return value of function
    'pthread_rwlock_unlock(struct pthread_rwlock **)' (compare with line 234,
    file /usr/include/pthread.h, module cache_acceptor.c)
/usr/include/pthread.h  234  Info 830: Location cited in prior message
                      _
	return backend;
cache_dir_dns.c  341  Warning 438: Last value assigned to variable 'ret'
    (defined at line 327) not used
cache_dir_dns.c  327  Info 830: Location cited in prior message
                                              _
	strncpy(hostname, p, sizeof(hostname));
cache_dir_dns.c  369  Warning 534: Ignoring return value of function
    'strncpy(char *, const char *, unsigned long)' (compare with line 98, file
    /usr/include/string.h, module cache_acceptor.c)
/usr/include/string.h  98  Info 830: Location cited in prior message
                                                                                  _
		strncat(hostname, vs->suffix, sizeof(hostname) - strlen(hostname));
cache_dir_dns.c  380  Warning 534: Ignoring return value of function
    'strncat(char *, const char *, unsigned long)' (compare with line 96, file
    /usr/include/string.h, module cache_acceptor.c)
/usr/include/string.h  96  Info 830: Location cited in prior message
        _
	return 1;
cache_dir_dns.c  414  Warning 527: Unreachable code at token 'return'
                                           _
	pthread_rwlock_destroy(&vs->rwlock);
cache_dir_dns.c  447  Warning 534: Ignoring return value of function
    'pthread_rwlock_destroy(struct pthread_rwlock **)' (compare with line 224,
    file /usr/include/pthread.h, module cache_acceptor.c)
/usr/include/pthread.h  224  Info 830: Location cited in prior message
_
}
cache_dir_dns.c  449  Warning 438: Last value assigned to variable 'vh'
    (defined at line 437) not used
cache_dir_dns.c  437  Info 830: Location cited in prior message
_
}
cache_dir_dns.c  449  Warning 550: Symbol 'vh' (line 437) not accessed
cache_dir_dns.c  437  Info 830: Location cited in prior message
                                              _
	pthread_rwlock_init(&vs->rwlock, NULL);
cache_dir_dns.c  485  Warning 534: Ignoring return value of function
    'pthread_rwlock_init(struct pthread_rwlock **, struct pthread_rwlockattr
    *const *)' (compare with line 226, file /usr/include/pthread.h, module
    cache_acceptor.c)
/usr/include/pthread.h  226  Info 830: Location cited in prior message

    --- Wrap-up for Module: cache_dir_dns.c

Info 754: local structure member 'vdi_dns::max_cache_size' (line 82, file
    cache_dir_dns.c) not referenced
cache_dir_dns.c  82  Info 830: Location cited in prior message

[...]

--- Module:   ../../lib/libvcl/vcc_dir_dns.c (C)
_
}
../../lib/libvcl/vcc_dir_dns.c  129  Info 818: Pointer parameter 'ip' (line 80)
    could be declared as pointing to const
../../lib/libvcl/vcc_dir_dns.c  80  Info 830: Location cited in prior message
                         _
	ip4 |= a[0] << 24;
../../lib/libvcl/vcc_dir_dns.c  148  Info 701: Shift left of signed quantity
    (int)
_
}
../../lib/libvcl/vcc_dir_dns.c  167  Info 818: Pointer parameter 'a' (line 141)
    could be declared as pointing to const
../../lib/libvcl/vcc_dir_dns.c  141  Info 830: Location cited in prior message
                                                                    _
		ret = sscanf(tl->t->dec, "%hhu.%hhu.%hhu.%hhu",&a[0],&a[1],&a[2],&a[3]);
../../lib/libvcl/vcc_dir_dns.c  261  Warning 561: (arg. no. 3) indirect object
    inconsistent with format
../../lib/libvcl/vcc_dir_dns.c  261  Warning 561: (arg. no. 4) indirect object
    inconsistent with format
../../lib/libvcl/vcc_dir_dns.c  261  Warning 561: (arg. no. 5) indirect object
    inconsistent with format
../../lib/libvcl/vcc_dir_dns.c  261  Warning 561: (arg. no. 6) indirect object
    inconsistent with format
                                              _
			mask = vcc_UintVal(tl);
../../lib/libvcl/vcc_dir_dns.c  266  Info 734: Loss of precision (assignment)
    (32 bits to 8 bits)
_
}
../../lib/libvcl/vcc_dir_dns.c  358  Warning 438: Last value assigned to
    variable 'nbh' (defined at line 280) not used
../../lib/libvcl/vcc_dir_dns.c  280  Info 830: Location cited in prior message
_
}
../../lib/libvcl/vcc_dir_dns.c  358  Warning 550: Symbol 'nbh' (line 280) not
    accessed
../../lib/libvcl/vcc_dir_dns.c  280  Info 830: Location cited in prior message

    --- Wrap-up for Module: ../../lib/libvcl/vcc_dir_dns.c

Info 844: Pointer variable 'dns_first' of type 'struct token *' (line 75, file
    ../../lib/libvcl/vcc_dir_dns.c) could be declared as pointing to const
../../lib/libvcl/vcc_dir_dns.c  75  Info 830: Location cited in prior message
Info 766: Header file '/usr/include/netdb.h' not used in module
    '../../lib/libvcl/vcc_dir_dns.c'

[...]

--- Module:   cache_dir_dns.c (C)
                                                                   _
	struct sockaddr_in6 *bps = (struct sockaddr_in6 *) bp->ipv6;
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 142: vdi_dns_comp_addrinfo6(?, ?, ?) #1
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)
                                   _
			addr, len));
cache_dir_dns.c  142  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 301: vdi_dns_comp_addrinfo(?, ?, ?) #1
cache_dir_dns.c  142  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  154  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  156  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  156  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  157  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  160  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  161  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  167  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  168  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  169  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message
                                                                _
	new->hostname = calloc(sizeof(char), strlen(hostname)+1);
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                    _
#... !(new->hostname != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "n
	assert(new->hostname != NULL);
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                       _
	strcpy(new->hostname, hostname);
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                        _
		return 0;
cache_dir_dns.c  291  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message
                                                               _
				new->hosts[host] = vs->hosts[i];
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... ew->hosts[host]) != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "
#... ssert((new->hosts[host]) != NULL); assert((new->hosts[host])->magic == 0x3
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... sts[host])->magic == 0x3336351d)) vas_fail(__func__, __FILE__, __LINE__, "
#... osts[host])->magic == 0x3336351d); } while (0)
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                          _
	new->nhosts = host;
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                _
	return 1;
cache_dir_dns.c  313  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  284  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  310  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

[...]

--- Module:   cache_dir_dns.c (C)
                                                                   _
	struct sockaddr_in6 *bps = (struct sockaddr_in6 *) bp->ipv6;
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 142: vdi_dns_comp_addrinfo6(?, ?, ?) #1
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 301: vdi_dns_comp_addrinfo(?, ?, ?) #1
  File cache_dir_dns.c line 142: vdi_dns_comp_addrinfo6(?, ?, ?) #2
cache_dir_dns.c  113  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)
                                                  _
	if (addr->sa_family == PF_INET && bp->ipv4) {
cache_dir_dns.c  137  Warning 613: Possible use of null pointer 'bp' in left
    argument to operator '->' [Reference: file cache_backend.c: line 552; file
    cache_dir_dns.c: line 136]
cache_backend.c  552  Info 831: Reference cited in prior message
cache_dir_dns.c  136  Info 831: Reference cited in prior message
                                                          _
	} else if (addr->sa_family == PF_INET6 && bp->ipv6) {
cache_dir_dns.c  140  Warning 613: Possible use of null pointer 'bp' in left
    argument to operator '->' [Reference: file cache_backend.c: line 552; file
    cache_dir_dns.c: line 136]
cache_backend.c  552  Info 831: Reference cited in prior message
cache_dir_dns.c  136  Info 831: Reference cited in prior message
                                   _
			addr, len));
cache_dir_dns.c  142  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 301: vdi_dns_comp_addrinfo(?, ?, ?) #1
cache_dir_dns.c  137  Warning 613: Possible use of null pointer 'bp' in left
    argument to operator '->' [Reference: file cache_backend.c: line 552; file
    cache_dir_dns.c: line 136]
cache_backend.c  552  Info 831: Reference cited in prior message
cache_dir_dns.c  136  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 301: vdi_dns_comp_addrinfo(?, ?, ?) #1
cache_dir_dns.c  140  Warning 613: Possible use of null pointer 'bp' in left
    argument to operator '->' [Reference: file cache_backend.c: line 552; file
    cache_dir_dns.c: line 136]
cache_backend.c  552  Info 831: Reference cited in prior message
cache_dir_dns.c  136  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 301: vdi_dns_comp_addrinfo(?, ?, ?) #1
cache_dir_dns.c  142  Info 826: Suspicious pointer-to-pointer conversion (area
    too small)

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  154  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  156  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  156  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  157  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  160  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  161  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  167  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  168  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 312: vdi_dns_pick_host(?, [1]? | 0?) #2
cache_dir_dns.c  169  Warning 613: Possible use of null pointer 'group' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: lines 281, 312]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
cache_dir_dns.c  312  Info 831: Reference cited in prior message
                                                                _
	new->hostname = calloc(sizeof(char), strlen(hostname)+1);
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                    _
#... !(new->hostname != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "n
	assert(new->hostname != NULL);
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                       _
	strcpy(new->hostname, hostname);
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                        _
		return 0;
cache_dir_dns.c  291  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message
                                                               _
				new->hosts[host] = vs->hosts[i];
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... ew->hosts[host]) != ((void *)0))) vas_fail(__func__, __FILE__, __LINE__, "
#... ssert((new->hosts[host]) != NULL); assert((new->hosts[host])->magic == 0x3
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                                                                                  _
#... sts[host])->magic == 0x3336351d)) vas_fail(__func__, __FILE__, __LINE__, "
#... osts[host])->magic == 0x3336351d); } while (0)
				CHECK_OBJ_NOTNULL(new->hosts[host], DIRECTOR_MAGIC);
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                          _
	new->nhosts = host;
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message
                _
	return 1;
cache_dir_dns.c  313  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  284  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #1
cache_dir_dns.c  310  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  284  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, ?, [1]) #2
cache_dir_dns.c  310  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  282  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  283  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  284  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  284  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  302  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  303  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  310  Warning 613: Possible use of null pointer 'new' in left
    argument to operator '->' [Reference: file cache_dir_dns.c: line 281]
cache_dir_dns.c  281  Info 831: Reference cited in prior message

During Specific Walk:
  File cache_dir_dns.c line 382: vdi_dns_walk_cache(?, ?, [1025]) #1
  File cache_dir_dns.c line 333: vdi_dns_cache_add(?, ?, [1025], [1]) #3
cache_dir_dns.c  310  Warning 429: Custodial pointer 'new' (line 267) has not
    been freed or returned
cache_dir_dns.c  267  Info 830: Location cited in prior message

[...]

--- Global Wrap-up

[...]
Info 765: external 'b_defaults' (line 62, file ../../lib/libvcl/vcc_dir_dns.c)
    could be made static
../../lib/libvcl/vcc_dir_dns.c  62  Info 830: Location cited in prior message

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.




More information about the varnish-misc mailing list