X-Forwarded-For automatically set in varnish 4.0?

[Nicolas Delmas]

Hello,

Why is this part if code useless ?
Is that because this code is in the builtin.vcl ?

Thanks

Le 14 févr. 2017 10:10 AM, "Guillaume Quintard" <
guillaume at varnish-software.com> a écrit :

> Hi,
>
> The snippet is legacy code for v3, and it's now useless/counter-productive
> in v4.
>
> --
> Guillaume Quintard
>
> On Tue, Feb 14, 2017 at 9:20 AM, Donath, Niklas <
> Niklas.Donath at lvdigital.de> wrote:
>
>> Hi there,
>>
>>
>>
>> actually, i am in a migration project from varnish 3 to varnish 4.0, and
>> i was confused about the x-forwarded-for header settings in varnish 4.0:
>>
>> in the official doc, it says that x-forwarded-for is automatically set,
>> like it is obvious in the source code: https://github.com/varnishcach
>> e/varnish-cache/blob/4.0/bin/varnishd/cache/cache_req_fsm.c#L724
>>
>>
>>
>> But a lot of people are adding a snippet for vcl_recv like
>>
>>
>>
>> if (req.restarts == 0) {
>>
>>     if (req.http.X-Forwarded-For) {
>>
>>         set req.http.X-Forwarded-For = req.http.X-Forwarded-For + ", " +
>> client.ip;
>>
>>     } else {
>>
>>         set req.http.X-Forwarded-For = client.ip;
>>
>>     }
>>
>> }
>>
>>
>>
>> Which, from my point of view, is the same implementation as it already
>> should exist as the docs say. I currently do not have a LB/proxy
>> infrastructure to test it, so maybe someone can clear this up, if
>> x-forwarded-for is automatically set by varnish before executing the
>> vcl_recv from my custom .vcl-file, or if the given snippet is required to
>> set the real user ip for x-forwarded-for.
>>
>>
>>
>> Thank you very much!
>>
>>
>>
>> Greetings, Niklas
>>
>>
>>
>> _______________________________________________
>> varnish-misc mailing list
>> varnish-misc at varnish-cache.org
>> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc
>>
>
>
> _______________________________________________
> varnish-misc mailing list
> varnish-misc at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-misc
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-misc/attachments/20170216/c33520d0/attachment.html>