r110 - in trunk/varnish-cache: include lib/libvarnish

Dag-Erling Smørgrav des at linpro.no
Tue Apr 4 11:34:23 CEST 2006


phk at projects.linpro.no writes:
> Log:
> Reverse constification of Argv functions.  After cascading through all
> the CLI functions we hit the fact that the evbuffer functions in libevent
> are not properly constified.
>
> It's better to deconst the error messages and just "let it be known" that
> argv[0] is const (or NULL).

OK.  We should probably have a compat.h which defines __DECONST
(preferably with a better name) so we don't have to spell it out
everywhere, and a libcompat (statically linked) which defines
strlcat() etc.

The alternative is to strdup() the error message, which removes the
need for special-casing argv[0].

DES
-- 
Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no



More information about the varnish-commit mailing list