r2272 - in trunk/varnish-cache: bin/varnishd include

Poul-Henning Kamp phk at phk.freebsd.dk
Tue Nov 20 18:01:22 CET 2007


In message <ujr7ikc980h.fsf at false.linpro.no>, =?iso-8859-1?Q?Dag-Erling_Sm=F8rg
rav?= writes:
>"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
>> Dag-Erling Sm=F8rgrav <des at linpro.no> writes:
>> > Many of our assertions have side effects, so the condition needs to be
>> > evaluated even if we don't bother to check the result.  We should trust
>> > the compiler to eliminate code that has no effect.
>> Are we going to allow the asserts to be compiled out ?
>
>We don't, currently, but we might.  In fact, I think we *should*, in
>the long run.

Hmm, I generally tend to make sure asserts are cheap and then leave
them in.  It's not like the conditions become more acceptable because
you run production :-)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



More information about the varnish-commit mailing list