r2272 - in trunk/varnish-cache: bin/varnishd include

Dag-Erling Smørgrav des at linpro.no
Tue Nov 20 18:30:53 CET 2007

"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
> Hmm, I generally tend to make sure asserts are cheap and then leave
> them in.  It's not like the conditions become more acceptable because
> you run production :-)

That's a good principle, but where do you draw the line between
keeping assertions cheap enough, and adding enough of them to matter?
I prefer to have the option of compiling them out so I don't have to
worry about how expensive they are.  There is no obviously expensive
stuff in our assertions today (the obviously expensive stuff is in
#ifdef DIAGNOSTICS), but even the cheap stuff adds up (and increases
code size, which may hurt cache locality)

Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no

More information about the varnish-commit mailing list