r2180 - trunk/varnish-cache/lib/libvarnishapi

Poul-Henning Kamp phk at phk.freebsd.dk
Mon Oct 29 16:28:07 CET 2007

In message <ujr1wbeasnb.fsf at false.linpro.no>, =?iso-8859-1?Q?Dag-Erling_Smørg
rav?= writes:
>phk at projects.linpro.no writes:
>> Log:
>> Mask negative characters to 8 bit before formatting.
>A cast would be more appropriate...  and we should probably use
>isprint() instead of hardcoding (*ptr >= ' ' && *ptr <= '~').

A cast we can discuss, but isprint() would be wrong because it would
take the locale into consideration and HTTP is specifically specified
in ASCII with no extension.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-commit mailing list