r2180 - trunk/varnish-cache/lib/libvarnishapi

Dag-Erling Smørgrav des at linpro.no
Mon Oct 29 16:44:47 CET 2007

"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
> "Dag-Erling Smørgrav" <des at linpro.no> writes:
> > A cast would be more appropriate...  and we should probably use
> > isprint() instead of hardcoding (*ptr >= ' ' && *ptr <= '~').
> A cast we can discuss, but isprint() would be wrong because it would
> take the locale into consideration and HTTP is specifically specified
> in ASCII with no extension.

We already force the time zone to UTC, there is no reason not to force
the locale to "C".

Alternatively, we can provide our own ASCII-only implementation - I
really don't like (*ptr >= ' ' && *ptr <= '~').

Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no

More information about the varnish-commit mailing list