[master] 3fe20d0 Check return value from VSB_finish

Martin Blix Grydeland martin at varnish-cache.org
Wed Oct 2 13:13:25 CEST 2013


commit 3fe20d03f1d6d1167f0e4196579660200ba7117b
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Wed Oct 2 13:04:14 2013 +0200

    Check return value from VSB_finish
    
    Spotted by: Coverity

diff --git a/lib/libvarnishapi/vsl_query.c b/lib/libvarnishapi/vsl_query.c
index 40780bb..6ec44b4 100644
--- a/lib/libvarnishapi/vsl_query.c
+++ b/lib/libvarnishapi/vsl_query.c
@@ -295,7 +295,7 @@ vslq_newquery(struct VSL_data *vsl, enum VSL_grouping_e grouping,
 	vsb = VSB_new_auto();
 	AN(vsb);
 	vex = vex_New(querystring, vsb);
-	VSB_finish(vsb);
+	AZ(VSB_finish(vsb));
 	if (vex == NULL)
 		vsl_diag(vsl, "%s", VSB_data(vsb));
 	else {



More information about the varnish-commit mailing list