[master] 3ad1666 Remove the test of varnishtest -i with an empty argument.

Dridi Boukelmoune dridi at varni.sh
Thu Dec 14 16:38:28 UTC 2017


Hi!

On Mon, Oct 23, 2017 at 8:20 PM, Geoff Simmons <geoff at uplex.de> wrote:
>
> commit 3ad16662cda0510a88a04fe86f264156583b8f20
> Author: Geoff Simmons <geoff at uplex.de>
> Date:   Mon Oct 23 20:17:36 2017 +0200
>
>     Remove the test of varnishtest -i with an empty argument.
>
>     Getting the quoting right to pass along the empty string in SunOS
>     is not working.

You can get all the quoting you want it won't work, because bug ;)

>     The code path is tested in vsl_glob_test.

I have a workaround if we want to revive this check, let me know.

Dridi

> diff --git a/bin/varnishtest/tests/u00006.vtc b/bin/varnishtest/tests/u00006.vtc
> index 24f69ca..8dcb2f9 100644
> --- a/bin/varnishtest/tests/u00006.vtc
> +++ b/bin/varnishtest/tests/u00006.vtc
> @@ -38,8 +38,6 @@ shell -err -expect {-i: "Resp" is ambiguous} \
>         "varnishlog -i Resp"
>  shell -err -expect {-i: Syntax error in "Re**sp"} \
>         "varnishlog -i Re**sp"
> -shell -err -expect {-i: "" matches zero tags} \
> -       {varnishlog -i ""}
>
>  shell -err -expect {-I: "foo" matches zero tags} \
>         "varnishlog -I foo:bar"
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit


More information about the varnish-commit mailing list