[master] 3ad1666 Remove the test of varnishtest -i with an empty argument.

[Geoff Simmons]

On 12/14/2017 05:38 PM, Dridi Boukelmoune wrote:

> I have a workaround if we want to revive this check, let me know.

Well, what does the workaround do?

The way I see it personally, we should automatically test as much of the
code as we can, but if we do in fact test that path adequately with the
vsl_glob_test, it doesn't seem urgent to restore the vtc test.

IIRC we were trying to get VTEST back to green, since some of the tests
were failing with disturbing consistency.

One of them, I think it was this one, resulted in the process table on
the SunOS system being filled up with varnishtest zombies, which
eventually led almost all of the tests failing.

I remember spending a full day fighting with the shell quoting, until we
finally gave up, and really don't want to have to do that again. But if
there's a nice workaround that avoids the trouble, well sure.


Best,
Geoff
-- 
** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

Tel +49 40 2880 5731
Mob +49 176 636 90917
Fax +49 40 42949753

http://uplex.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20171214/d1591d80/attachment-0001.bin>