[master] f4d0280 Return early on failure

Poul-Henning Kamp phk at phk.freebsd.dk
Fri Nov 3 07:24:58 UTC 2017


--------
In message <CABoVN9Aeoe_XOfa84-Bif-71O4CV+KWq8gvSM=FbVwTekiQacQ at mail.gmail.com>
, Dridi Boukelmoune writes:
>On Thu, Nov 2, 2017 at 1:02 PM, Poul-Henning Kamp <phk at freebsd.org> wrote:
>>
>> commit f4d02803c5dfded27b446d39039dc02f02b3717c
>> Author: Poul-Henning Kamp <phk at FreeBSD.org>
>> Date:   Thu Nov 2 07:44:16 2017 +0000
>>
>>     Return early on failure
>
>You might want to VRT_fail before returning too.

We do that in vtc_ws_find() in the new functions in vmod_vrt,
but the old (to be removed) functions in vmod_debug never did that.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-commit mailing list