[master] f4d0280 Return early on failure

Dridi Boukelmoune dridi at varni.sh
Fri Nov 3 14:24:39 UTC 2017

On Fri, Nov 3, 2017 at 8:24 AM, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> --------
> In message <CABoVN9Aeoe_XOfa84-Bif-71O4CV+KWq8gvSM=FbVwTekiQacQ at mail.gmail.com>
> , Dridi Boukelmoune writes:
>>On Thu, Nov 2, 2017 at 1:02 PM, Poul-Henning Kamp <phk at freebsd.org> wrote:
>>> commit f4d02803c5dfded27b446d39039dc02f02b3717c
>>> Author: Poul-Henning Kamp <phk at FreeBSD.org>
>>> Date:   Thu Nov 2 07:44:16 2017 +0000
>>>     Return early on failure
>>You might want to VRT_fail before returning too.
> We do that in vtc_ws_find() in the new functions in vmod_vrt,
> but the old (to be removed) functions in vmod_debug never did that.

Indeed, I polished the code for the debug-to-vtc transition, and
apparently I took care of the VRT_fail call but not the early return.
I assumed not since it wasn't in the diff, my bad...


More information about the varnish-commit mailing list