[master] 8c2ed01 Propagate the VCL syntax to VRT_CTX.

Dridi Boukelmoune dridi at varni.sh
Tue Feb 6 10:35:05 UTC 2018

On Tue, Feb 6, 2018 at 11:30 AM, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> --------
> In message <CABoVN9CWEPhPGHbbzj5ygsZ7D6g+fgVBORUzpmEhUPj_PJH7MA at mail.gmail.com>
> , Dridi Boukelmoune writes:
>>Can we avoid vocabulary overloading here? I know that on the C side we
>>refer to subs as methods (and maybe we should change that) but in the
>>documentation we call them subroutines.
> Uhm, thinking more about it:
> so if "sub vcl_recv {}" is a subroutine, what is "sub foobar {}"

Also a subroutine.

> and how do we explain that "sub vcl_foobar{}" is not OK ?

That's what the error message you edited does, then it lists the
reserved subroutines.

Arguably we could do this:

-VSB_printf(tl->sb, "Valid vcl_* subroutines are:\n");
+VSB_printf(tl->sb, "Reserved vcl_* subroutines are:\n");

For "The names 'vcl*' are reserved for subroutines.\n" the previous
incarnation did a better job: "VCL sub's named 'vcl*' are reserved


More information about the varnish-commit mailing list