[master] e89586b Add proxy/cache_proxy.h to varnishd_SOURCES.

Dridi Boukelmoune dridi at varni.sh
Wed Mar 14 18:18:54 UTC 2018


On Wed, Mar 14, 2018 at 5:10 PM, Geoff Simmons <geoff at uplex.de> wrote:
>
> commit e89586b69f919d4f836db10a33ad2136cff1340c
> Author: Geoff Simmons <geoff at uplex.de>
> Date:   Wed Mar 14 16:52:54 2018 +0100
>
>     Add proxy/cache_proxy.h to varnishd_SOURCES.
>
> diff --git a/bin/varnishd/Makefile.am b/bin/varnishd/Makefile.am
> index a033001..739b16c 100644
> --- a/bin/varnishd/Makefile.am
> +++ b/bin/varnishd/Makefile.am
> @@ -90,6 +90,7 @@ varnishd_SOURCES = \
>         mgt/mgt_vcc.c \
>         mgt/mgt_vcl.c \
>         proxy/cache_proxy_proto.c \
> +       proxy/cache_proxy.h \
>         storage/mgt_stevedore.c \
>         storage/stevedore.c \
>         storage/stevedore_utils.c \

I said I would review the vmod-proxy patch set but also said you
shouldn't wait for me, but still, I'm complaining as I'm discovering
this after the facts.

Please don't take the habit of checking in patches that are known to
be broken. When we look for regressions with git-bisect it diminishes
the benefits of automation when we have to waste eyeballs time on
false-negative.

Dridi


More information about the varnish-commit mailing list