[master] e89586b Add proxy/cache_proxy.h to varnishd_SOURCES.

Geoff Simmons geoff at uplex.de
Wed Mar 14 18:55:10 UTC 2018


On 03/14/2018 07:18 PM, Dridi Boukelmoune wrote:
>>
>> commit e89586b69f919d4f836db10a33ad2136cff1340c
>> Author: Geoff Simmons <geoff at uplex.de>
>> Date:   Wed Mar 14 16:52:54 2018 +0100
>>
>>     Add proxy/cache_proxy.h to varnishd_SOURCES.
>>
> 
> Please don't take the habit of checking in patches that are known to
> be broken. When we look for regressions with git-bisect it diminishes
> the benefits of automation when we have to waste eyeballs time on
> false-negative.

Understood. I was thinking of keeping my commits separate from ehocdet's
for the PR, but yes this one could have been squashed.

I'm curious as to why Travis put the green checkmark on the PR. Doesn't
Travis run make distcheck?


Best,
Geoff
-- 
** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

Tel +49 40 2880 5731
Mob +49 176 636 90917
Fax +49 40 42949753

http://uplex.de

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20180314/0182070a/attachment.bin>


More information about the varnish-commit mailing list