[master] 7da6220df Assert

Nils Goroll nils.goroll at uplex.de
Mon Dec 16 13:05:56 UTC 2019


my thinking was that two WS_Asserts were overkill and I think a
CHECK_OBJ_NOTNULL would actually make more sense.

On 16/12/2019 12:23, Dridi Boukelmoune wrote:
> On Mon, Dec 16, 2019 at 11:18 AM Nils Goroll <nils.goroll at uplex.de> wrote:
>>
>> there already was one 4 lines below, that does checking twice gain?
> 
> We dereference ws before we even check we have a correct one, so
> either we opt for at least a null check or a miniobj check, or we go
> for the complete workspace check.
> 
> I chose the latter because the deprecated WS_Reserve does that and its
> replacement doesn't.
> 
> Dridi
> 


-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20191216/37be26a8/attachment.bin>


More information about the varnish-commit mailing list