[master] b73c8827b document removed return(miss) from vcl_hit

Nils Goroll nils.goroll at uplex.de
Mon Mar 4 13:10:09 UTC 2019


commit b73c8827bc84439eba6994750c8889188d94ce2b
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Mon Mar 4 14:09:01 2019 +0100

    document removed return(miss) from vcl_hit
    
    Ref #2859 #1799

diff --git a/doc/sphinx/whats-new/changes-trunk.rst b/doc/sphinx/whats-new/changes-trunk.rst
index 04dc342a8..521427c37 100644
--- a/doc/sphinx/whats-new/changes-trunk.rst
+++ b/doc/sphinx/whats-new/changes-trunk.rst
@@ -78,6 +78,10 @@ component listening at the socket, or set the socket's permissions,
 after starting Varnish or loading VCL. If the socket still cannot be
 accessed when a fetch is attempted, then the fetch fails.
 
+``return(miss)`` from ``vcl_hit{}`` did never work as intended for the
+common case (it actually turned into a pass), so we now removed it and
+changed the ``builtin.vcl``.
+
 VMODs
 =====
 
diff --git a/doc/sphinx/whats-new/upgrading-trunk.rst b/doc/sphinx/whats-new/upgrading-trunk.rst
index e46362048..9eaa3b662 100644
--- a/doc/sphinx/whats-new/upgrading-trunk.rst
+++ b/doc/sphinx/whats-new/upgrading-trunk.rst
@@ -44,6 +44,15 @@ listening at the socket, or set its permissions, after Varnish starts
 or the VCL is loaded. Backend fetches fail if the socket is not
 accessible by the time the fetch is attempted.
 
+
+``return(miss)`` from ``vcl_hit{}`` is now removed. Options to
+implement similar functionality are:
+
+* a vmod using the new *catflap* mechanism
+
+* ``return (restart)`` from ``vcl_hit{}`` and ``set
+  req.hash_always_miss = true;`` in ``vcl_recv{}`` for the restart.
+
 Runtime parameters
 ==================
 


More information about the varnish-commit mailing list