[master] d6d341609 Revert "actually, the scope must not change either"

Dridi Boukelmoune dridi at varni.sh
Mon May 27 08:41:46 UTC 2019


On Mon, May 27, 2019 at 10:22 AM Nils Goroll <nils.goroll at uplex.de> wrote:
>
> > You should also thank Martin without whom I would have remained on the
> > wrong track probably until today's bugwash.
>
> Thank you, Martin! And I apologize for my bug.
>
> >> I wonder if it wouldn't make more sense to give PRIV_TOP its own tree head
> >> rather than an additional id to put into a shared tree?
> >
> > I have no opinion (but I understand the rationale) so I will leave
> > this question to the rest of the team.
>
> Using a different head would use less memory, be more CPU efficient and also, I
> think, result in simpler code. So a clear cut case in my opinion.

Also less branches in general, trivial to implement etc... But I'll stay
on my proverbial fence :)

Dridi


More information about the varnish-commit mailing list