[master] 9db32058b Kill dead assert

Nils Goroll nils.goroll at uplex.de
Tue Mar 3 13:34:35 UTC 2020


On 03/03/2020 14:30, Dridi Boukelmoune wrote:
> What about turning enum vcl_event_e into a struct that has fields for
> both method and have_msg properties? That would be for 7.0 of
> course...

I do not share the disgust for enums, but that could make the code cleaner/more
readable.

I would not touch the VMOD/VCL facing side though, the struct could still
contain the vcl_event_e to be passed to the vmod event function.

Nils

-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20200303/a01b1ba0/attachment.bin>


More information about the varnish-commit mailing list