[master] 9db32058b Kill dead assert

Dridi Boukelmoune dridi at varni.sh
Tue Mar 3 13:40:19 UTC 2020

On Tue, Mar 3, 2020 at 1:34 PM Nils Goroll <nils.goroll at uplex.de> wrote:
> On 03/03/2020 14:30, Dridi Boukelmoune wrote:
> > What about turning enum vcl_event_e into a struct that has fields for
> > both method and have_msg properties? That would be for 7.0 of
> > course...
> I do not share the disgust for enums, but that could make the code cleaner/more
> readable.

Disgust was not the driver for this suggestion :)

> I would not touch the VMOD/VCL facing side though, the struct could still
> contain the vcl_event_e to be passed to the vmod event function.

Interesting middle ground!


More information about the varnish-commit mailing list