[master] 4ed6181f8 Fix a wrap-around issue in buffered VSLs

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Nov 16 17:49:57 UTC 2022


--------
Dridi Boukelmoune writes:
> On Wed, Nov 16, 2022 at 5:29 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> >
> > --------
> > Dridi Boukelmoune writes:
> > > On Wed, Nov 16, 2022 at 4:55 PM Poul-Henning Kamp <phk at freebsd.org> wrote:
> >
> > > > +static unsigned
> > > > +vsl_space(const struct vsl_log *vsl)
> > >
> > > Maybe rename to vslb_space for consistency?
> >
> > It is not specialized to vslb, it works on any vsl_log.
>
> I don't follow, either we have a vsl_log and it's buffered or we use
> the VSL() function and its variants.

Correct, but there may be future opportunities to use struct vsl_log
also for the global log.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-commit mailing list