[master] 4ed6181f8 Fix a wrap-around issue in buffered VSLs

Dridi Boukelmoune dridi at varni.sh
Wed Nov 16 17:53:05 UTC 2022


On Wed, Nov 16, 2022 at 5:49 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
>
> --------
> Dridi Boukelmoune writes:
> > On Wed, Nov 16, 2022 at 5:29 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> > >
> > > --------
> > > Dridi Boukelmoune writes:
> > > > On Wed, Nov 16, 2022 at 4:55 PM Poul-Henning Kamp <phk at freebsd.org> wrote:
> > >
> > > > > +static unsigned
> > > > > +vsl_space(const struct vsl_log *vsl)
> > > >
> > > > Maybe rename to vslb_space for consistency?
> > >
> > > It is not specialized to vslb, it works on any vsl_log.
> >
> > I don't follow, either we have a vsl_log and it's buffered or we use
> > the VSL() function and its variants.
>
> Correct, but there may be future opportunities to use struct vsl_log
> also for the global log.

ACK


More information about the varnish-commit mailing list