Another fine point of C-language

Poul-Henning Kamp phk at
Mon Sep 24 22:45:08 CEST 2007

Some of the FreeBSD <sys/mumble.h> files include <sys/queue.h>,
for instance <sys/mount.h> and <sys/event.h>

That means that sometimes we get the official FreeBSD version of
queue.h and sometimes we get the Varnish copy of the same.

By definition we cannot use the Varnish copy for the FreeBSD system
includes, but we could use the FreeBSD copy for the Varnish sources,
if we wanted to.

As long as they are identical, this is not a problem for anything but
really anal souce-code-groking tools like FlexeLint, but down the
road, if FreeBSD changes <sys/queue.h> in any significant way,
this would be a nasty bug to spot.

I think I would prefer if we stick with the system version of
<sys/queue.h> if there is one we can use and reserve or private
copy of it for systems that don't have it already.

I have no idea how much autocrap magic that requires...

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list