Move re test method into libvcl

Poul-Henning Kamp phk at
Sun Apr 13 09:03:17 CEST 2008

In message <F39ABE22-D50C-429E-9A38-FF905A80DD3F at>, Paul Nasrat w
>On 12 Apr 2008, at 19:19, Poul-Henning Kamp wrote:
>> Your patch breaks the convention that compiled code only calls VRT_*
>> functions, you need to keep a VRT_re_test() wrapper around for that
>> reason.
>I'm not sure that's breaking that convention - the call chain is in  
>vcc_regexp and it's a test before generating the C for the compiled  
>vcl binary. Maybe I'm misunderstanding what you mean by "compiled  
>code" in this case - I think that you mean that any generated C from  
>vcl should only call VRT_* functions, which this patch doesn't change,  
>as it's a validity check before code generation occurs.

Correct, but your patch removes a VRT_ function which the generated
code needs in order to run...

>I looked on  
>but didn't see a mention of this convention - is there another place I  
>should be looking so that I can understand the coding conventions of  
>the project?

They're not well documented, sorry.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list