[PATCH] Automatically expand vmod_* macros in varnishtest

Dridi Boukelmoune dridi at varni.sh
Thu Feb 18 09:58:07 CET 2016


>>varnishtest -i already sets the PATH for the programs, should those
>>macros also be retired and leave it to varnishtest users to set an
>>appropriate PATH?
>
> No, -i is shortcut for "I'm running in the build-tree" and it should
> retain that meaning.

Bit of misunderstanding here. I say that varnishtest -i already sets
an appropriate PATH, so without a -D for instance ${varnishd} will
always expand to varnishd.

My question was about dropping the ${varnish*} macros and let
varnishtest users do this kind of PATH setting, just like varnishtest
-i currently does. I have no intention in changing the -i behavior.

In my vmod-example patch, varnishtest is run like this:

  env PATH=@TEST_PATH@ varnishtest -v ...

And the TEST_PATH is created by the configure script:

  AC_SUBST(
    [TEST_PATH],
    [$LIBVARNISHAPI_SBINDIR:$LIBVARNISHAPI_BINDIR:$PATH])

This is what I mean by letting the varnishtest user figure the PATH
for the tools, and retire the ${varnish*} macros.

> In the new world order, it should append appropriately to vmod_path.

s/append/prepend/ ?



More information about the varnish-dev mailing list