[PATCH] Automatically expand vmod_* macros in varnishtest

Poul-Henning Kamp phk at phk.freebsd.dk
Thu Feb 18 10:30:46 CET 2016


--------
In message <CABoVN9DXmf=t6KhQsX=keApuz=WJ8GX+-pNJQ+88DOM4JM_pJA at mail.gmail.com>, Dridi Boukelmoune writes:

>> No, -i is shortcut for "I'm running in the build-tree" and it should
>> retain that meaning.
>
>Bit of misunderstanding here. I say that varnishtest -i already sets
>an appropriate PATH, so without a -D for instance ${varnishd} will
>always expand to varnishd.
>
>My question was about dropping the ${varnish*} macros and let
>varnishtest users do this kind of PATH setting, just like varnishtest
>-i currently does. I have no intention in changing the -i behavior.

Ohh, I'd forgotten about that.  yes, in that case we should
drop the ${varnishstat} macros as well.

>> In the new world order, it should append appropriately to vmod_path.
>
>s/append/prepend/ ?

I guess the PATH codes sets the precedent that we prepend, and that
is probably the most robust choice

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



More information about the varnish-dev mailing list