[master] b6d0ff8 Merge tests and reshuffle things

Dridi Boukelmoune dridi at varni.sh
Sat Jan 28 01:19:18 CET 2017

On Fri, Jan 27, 2017 at 9:21 PM, Federico Schwindt <fgsch at lodoss.net> wrote:
> Not happy about hiding the error but it will do it for now.
> The tests are not using a hardcoded port anymore and should fail with the
> expected error now.

Your test case is misleading because it pretends to be safe, but either
${v1_port} is bound when you're using it the test can't [1] possibly pass,
or it's available for anyone to bind and you run into the same
concurrency problem again.

> Why this is a problem in sunos is beyond to me at the moment.

SunOS, FreeBSD, and my Linux box. I tried to get rid of the hard-coded
port too but didn't manage, so I kept it as close as the original test.

This is very simple: varnishtest doesn't offer enough isolation to safely
run this test, especially with concurrent jobs.


[1] Except maybe with SO_REUSEPORT, but... can of worms?

More information about the varnish-dev mailing list