[master] a4e07fc Correct this test for good

Dridi Boukelmoune dridi at varni.sh
Sat Jan 28 19:30:29 CET 2017

On Sat, Jan 28, 2017 at 7:03 PM, Federico G. Schwindt <fgsch at lodoss.net> wrote:
> commit a4e07fc5a611062afddd2fb114d43d793054c15f
> Author: Federico G. Schwindt <fgsch at lodoss.net>
> Date:   Sat Jan 28 14:38:50 2017 +0000
>     Correct this test for good
>     (Ab)use the bound address used for the bad_backend macro to expose a
>     random port and avoid the dreaded collisions.

This is a topic I actually wanted to bring up to the next bugwash (I
couldn't attend last Monday) and while ${bad_backend} is convenient
for testing, it relies on brittle behavior from the way varnish does
host/port resolution. It doesn't question tests relying on this macro
and the new ${random_port}. I found both names misleading too.

As for the solution to this particular problem, I find it quite
elegant naming aside.


More information about the varnish-dev mailing list