VMOD havoc generating patch
dridi at varni.sh
Mon Feb 4 21:25:19 UTC 2019
On Mon, Feb 4, 2019 at 8:30 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> In message <CABoVN9BOLePiYW3tVLVj1vK6fOn23YkHw2znpCTvf936sL7Tcw at mail.gmail.com>, Dridi Boukelmoune writes:
> >On Mon, Jan 28, 2019 at 1:55 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> >I waited until my weekly CI against master would choke on this change,
> >and it's very easy to support both before and after if your baseline
> >is 6.0, which is more than fine since 4.1 only has a couple months to
> > #include "vcc_$VMOD_if.h"
> > /* Varnish < 6.2 compat */
> > #ifndef VPFX
> > #define VPFX(a) vmod_ ## a
> > #define VARGS(a) vmod_ ## a ## _arg
> > #define VENUM(a) vmod_enum_ ## a
> > #endif
> >I didn't try on a vmod with a $Prefix stanza, but I'm sure it can be
> >helped if that snippet is not enough.
> Yes, that would go a long way towards compatibility.
It seems incomplete though, currently the $Prefix is applied all over
the place and the VPFX macro isn't used for function names. Is that
still work in progress?
More information about the varnish-dev