VMOD havoc generating patch

Poul-Henning Kamp phk at phk.freebsd.dk
Tue Feb 5 09:17:05 UTC 2019

In message <CABoVN9DZkhCtchRvBzh+zP0jwheex1=WVFdOMC7NJ-MfFgyiGA at mail.gmail.com>, Dridi Boukelmoune writes:

>No, I mean when I look at the generated vcc_$VMOD_if.h, I see many
>occurrences of the $Prefix that are not guarded by VPFX() macros.

The VPFX/VARGS/VENUM macros are mostly intended as convenience for the
files the vmod-author writes.

I didn't VPFX the prototypes to not _force_ people to use the VPFX
in their code if they dont want to, but if the consensus is that
we should be pushing VPFX() usage, changing it is just stylistic.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list